Skip to content

Conversation

@wholmgren
Copy link
Member

@wholmgren wholmgren commented Mar 13, 2021

  • Closes move ModelChain.times, weather to ModelChainResult #1164
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

@wholmgren wholmgren added the api label Mar 13, 2021
@wholmgren wholmgren added this to the 0.9.0 milestone Mar 13, 2021
@wholmgren wholmgren merged commit 933d0d8 into pvlib:master Mar 18, 2021
@wholmgren wholmgren deleted the wxtimestomcresults branch March 18, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move ModelChain.times, weather to ModelChainResult

2 participants