Fix fuentes error for tz-aware inputs #1072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wholmgren
approved these changes
Oct 8, 2020
pvlib/temperature.py
Outdated
| @@ -599,7 +599,8 @@ def fuentes(poa_global, temp_air, wind_speed, noct_installed, module_height=5, | |||
| # n.b. the way Fuentes calculates the first timedelta makes it seem like | |||
| # the value doesn't matter -- rather than recreate it here, just assume | |||
| # it's the same as the second timedelta: | |||
| timedelta_hours = np.diff(poa_global.index).astype(float) / 1e9 / 60 / 60 | |||
| timedeltas = (poa_global.index[1:] - poa_global.index[:-1]) | |||
There was a problem hiding this comment.
is this equivalent to poa_global.index.to_series().diff().total_seconds() / 3600?
There was a problem hiding this comment.
The type is different (series vs index), but that doesn't matter in this context. With timedelta_hours.iloc[0] = timedelta_hours.iloc[1], the two are equivalent, so I'll use yours 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates entries todocs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.Works locally, seeing if the CI likes it.