Requirements in setup.py are redundant, and partially inconsistent, with requirements.txt

[kandersolar]

index.rst advertises the contents of requirements.txt as the package's dependencies:

pvanalytics/requirements.txt

Lines 1 to 6 in a3d3860

	numpy>=1.15.0
	pandas>=0.24.0,<1.1.0
	pvlib>=0.8.0
	scipy>=1.2.0
	statsmodels>=0.9.0
	scikit-image>=0.16.0

But the pandas version range specified in setup.py is in fact slightly different (ref):

pvanalytics/setup.py

Lines 33 to 40 in a3d3860

	INSTALL_REQUIRES = [
	'numpy >= 1.15.0',
	'pandas >= 0.24.0',
	'pvlib >= 0.8.0',
	'scipy >= 1.2.0',
	'statsmodels >= 0.9.0',
	'scikit-image >= 0.16.0'
	]

Worth considering having a "single source of truth" for the requirement ranges so that there's no way for redundant specs to get out of sync. I think some packages solve this by including a line in setup.py like this: INSTALL_REQUIRES = open('requirements.txt').read().split('\n'). Maybe eliminating requirements.txt and keeping version ranges in setup.py would make more sense in this case.

Same goes for DOCS_REQUIRE and docs/requirements.txt.

[wfvining]

Great suggestion @kanderso-nrel, I've got it on my to-do list to do some general maintenance on dependencies for this project (notably work to support higher versions of pandas) and it would be good to address this as well.

[wholmgren]

Worth reading this discussion of setup.py vs requirements.txt if you've not already done so: https://caremad.io/posts/2013/07/setup-vs-requirement/

It's now 8 years old (a lifetime in python packaging) but so far as I'm aware the advice still applies. TLDR: pvanalytics should not have requirements.txt files (at least that's my understanding)