This repository was archived by the owner on Dec 18, 2025. It is now read-only.
572 log recent credentials on dashboard #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not working atm.
…oesnt work and paper trail feature aren't included yet.
loads all encryptables of user
…edentials-on-dashboard
Not smart to do this in this branch This reverts commit 7c435b2.
…edentials-on-dashboard
Added personal log controller and other stuff.
…logs that i forgot before
… after opening an encryptable
mtnstar
suggested changes
May 17, 2022
Contributor
mtnstar
left a comment
mtnstar
left a comment
There was a problem hiding this comment.
nice work! almost done ...
- make sure you're using more accurate test data in specs
- eliminate n+1 query
check the other comments
…edentials-on-dashboard
…edentials-on-dashboard
…edentials-on-dashboard
Contributor
Author
|
all changes implemented and ready for review |
Robin481
suggested changes
May 20, 2022
Member
Robin481
left a comment
Robin481
left a comment
There was a problem hiding this comment.
Yea looking good!
Some small technicalities and a bit of me just having a bit too much fun.
Good job! 🏆
Contributor
Author
Member
|
Boom 💥 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specs are not complete yet, but implementation is ready for review.