Skip to content

Fix double main invocation using shim mode #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Fix double main invocation using shim mode #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37c12c2
Use shim mode to prevent double main invocation
JordanMartinez Aug 12, 2022
47a7c3c
Update changelog
JordanMartinez Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Breaking changes:
New features:

Bugfixes:
- Fix double `main` invocation (#295 by @JordanMartinez)

Other improvements:

Expand Down
8 changes: 1 addition & 7 deletions client/public/frame.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,7 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<script>
window.esmsInitOptions = {
// -- Hooks --
// Module load error
onerror: (e) => {
console.log("Error while loading module: ");
console.log(e);
throw e;
},
shimMode: true,
};
</script>
<!--
Expand Down