Tidy up client JS dependencies #146
Merged
+0
−100,825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runtime JS dependencies are obtained as follows: - dependencies for the main client window (eg jquery, ace) are obtained via cdnjs.cloudflare.com, and so we don't need anything beyond than the script tags in index.html. - dependencies needed inside the iframe (eg react, for gists which use react-based libraries like purescript-react or purescript-thermite) are obtained via the new 'shims' mechanism introduced by #128 / #136. The files I am removing in this commit do not appear to be in use. I've also removed non-purescript dependencies from bower.json, as they also do not appear to be in use.
|
Resolves #144 |
natefaubion
approved these changes
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime JS dependencies are obtained as follows:
via cdnjs.cloudflare.com, and so we don't need anything beyond than
the script tags in index.html.
react-based libraries like purescript-react or purescript-thermite)
are obtained via the new 'shims' mechanism introduced by Load individual modules on demand #128 / Merge changes from #128 #136.
The files I am removing in this commit do not appear to be in use. I've
also removed non-purescript dependencies from bower.json, as they also
do not appear to be in use.