Merge changes from #128 #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natefaubion
reviewed
Mar 10, 2020
Comment on lines
+12
to
+26
| shims :: Object Shim | ||
| shims = Object.fromFoldable | ||
| [ Tuple "react" | ||
| { url: "https://unpkg.com/[email protected]/umd/react.development.js" | ||
| , deps: [] | ||
| } | ||
| , Tuple "react-dom" | ||
| { url: "https://unpkg.com/[email protected]/umd/react-dom.development.js" | ||
| , deps: [ "react" ] | ||
| } | ||
| , Tuple "react-dom/server" | ||
| { url: "https://unpkg.com/[email protected]/umd/react-dom-server.browser.development.js" | ||
| , deps: [ "react" ] | ||
| } | ||
| ] |
There was a problem hiding this comment.
These versions probably need to be updated.
|
In what sense have the other backends not been removed? To me, it looks like they have been. The only remnants of the other backends I can find are the files in |
|
This looks great! I'm going to just go ahead and merge it (and update the shim versions). |
|
I've just noticed that link clicks no longer work, presumably because of the new iframe. Perhaps we can handle this by listening for the iframe load event and navigating to the new location manually? |
|
Oh I see, there's also the contents of |
hdgarrood
added a commit
that referenced
this pull request
Apr 11, 2020
Runtime JS dependencies are obtained as follows: - dependencies for the main client window (eg jquery, ace) are obtained via cdnjs.cloudflare.com, and so we don't need anything beyond than the script tags in index.html. - dependencies needed inside the iframe (eg react, for gists which use react-based libraries like purescript-react or purescript-thermite) are obtained via the new 'shims' mechanism introduced by #128 / #136. The files I am removing in this commit do not appear to be in use. I've also removed non-purescript dependencies from bower.json, as they also do not appear to be in use.
hdgarrood
added a commit
that referenced
this pull request
Apr 11, 2020
Runtime JS dependencies are obtained as follows: - dependencies for the main client window (eg jquery, ace) are obtained via cdnjs.cloudflare.com, and so we don't need anything beyond than the script tags in index.html. - dependencies needed inside the iframe (eg react, for gists which use react-based libraries like purescript-react or purescript-thermite) are obtained via the new 'shims' mechanism introduced by #128 / #136. The files I am removing in this commit do not appear to be in use. I've also removed non-purescript dependencies from bower.json, as they also do not appear to be in use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged the changes from #128 into master and updated
Try.Config.mainGistto point to my updated fork.In order to load the modules, it's necessary to copy the contents of
staging/core/.psci_modules/node_modules/intoclient/js/output/.@hdgarrood Again this is the bare minimum. The other backends haven't been removed, no READMEs have been updated, and none of the comments from #135 (review) have been implemented.
@natefaubion your changes are great! This will likely allow a lot of flexibility for people wanting to run TryPS locally.