Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Dhall-1.38 has been released: https://hackage.haskell.org/package/dhall-1.38.0/
This has a change in the input format detection in the
Dhall.Format.Formatdatatype: https://hackage.haskell.org/package/dhall-1.38.0/changelogVersion 1.37.1:
Version 1.38.0:
The
spagocodebase is passingDhall.Pretty.ASCII(which is aCharacterSet) to all the pretty-printing functions. This PR updates the code to passJust ASCII, which causes spago to render all dhall files in ASCII (even if the input dhall code uses unicode symbols).I did this because passing
Nothing(which should cause dhall format to use ASCII or Unicode based on the input file) causes one of the tests to fail. However, at some point it might make sense to change this test and have spago also output either ascii or unicode depending on the format of the input dhall file.Checklist:
READMEP.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊