Skip to content

Conversation

@f-f
Copy link
Member

@f-f f-f commented Sep 3, 2020

As per title, we disable the inclusion of the terminfo library when compiling, which in turn removes our dependency on libtinfo. This should remove a whole lot of issues about libtinfo compatibiity across distros, and remove the urgent need to have a static build.

This is a harmless change, since we inherit the dependency transitively from Dhall, which includes that for the REPL, which we don't use anywhere.

Copy link
Contributor

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@hdgarrood
Copy link
Contributor

What’s the output of running ldd on a binary with this change, just out of interest?

@f-f
Copy link
Member Author

f-f commented Sep 3, 2020

@hdgarrood

linux-vdso.so.1 (0x00007fff7dc7f000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f966fae9000)
libstdc++.so.6 => /lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f966f8fb000)
libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007f966f8df000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f966f8bc000)
librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f966f8b1000)
libutil.so.1 => /lib/x86_64-linux-gnu/libutil.so.1 (0x00007f966f8ac000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f966f8a4000)
libgmp.so.10 => /lib/x86_64-linux-gnu/libgmp.so.10 (0x00007f966f823000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f966f632000)
/lib64/ld-linux-x86-64.so.2 (0x00007f966fc60000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f966f618000)

@f-f f-f merged commit 7dcd30d into master Sep 3, 2020
@mergify mergify bot deleted the drop-libtinfo branch September 3, 2020 10:10
@f-f f-f mentioned this pull request Oct 30, 2020
@f-f f-f mentioned this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants