Update comments #661
Merged
Update comments #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-f
approved these changes
Jun 30, 2020
Member
f-f
left a comment
f-f
left a comment
There was a problem hiding this comment.
Left a small comment, but otherwise looks great, thanks! 👏
Member
|
This is good to go, but it looks like there's a test failing - I suspect we have fixtures trying to match on the content of the template |
Contributor
Author
|
It's caused by this line: - dhallSource `shouldSatisfy` (Text.isInfixOf "let overrides =") -- some dhall stuff is present
+ dhallSource `shouldSatisfy` (Text.isInfixOf "let upstream") -- some dhall stuff is present |
Member
|
Thank you! 💯 |
| let upstream = -- <package set URL here> | ||
| in upstream | ||
| with simple-json.repo = "https://github.com/my-user/purescript-simple-json.git" | ||
| with simple-json.verison = "701f3e44aafb1a6459281714858fadf2c4c2a977" |
Contributor
Author
There was a problem hiding this comment.
Dah! I'm pretty sure my fingers have muscle memory now in spelling this word wrong!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes #659
Checklist:
READMEP.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊