Skip to content

Conversation

paluh
Copy link
Contributor

@paluh paluh commented Oct 14, 2020

@JordanMartinez
Copy link
Contributor

Even though CI builds here, it shouldn't be merged since globals will be deprecated.

@JordanMartinez
Copy link
Contributor

JordanMartinez commented Nov 12, 2020

@paluh I believe the purescript/purescript-numbers#12 will be merged soon. Could you make the following changes? Once the numbers PR is merged, we can restart this PR's CI and it should build after that:

  • change the dependency from purescript-globals to purescript-numbers
  • in src/Performance/Minibench.purs, change import Global (infinity) to import Data.Number (infinity).

@JordanMartinez
Copy link
Contributor

Superceded by #14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants