Skip to content

make nubByEq more efficient, part of #71 #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2019
Merged

make nubByEq more efficient, part of #71 #154

merged 2 commits into from
Mar 31, 2019

Conversation

sharno
Copy link
Contributor

@sharno sharno commented Feb 11, 2019

make nubByEq more efficient, part of #71

hdgarrood
hdgarrood reviewed Feb 11, 2019
View reviewed changes
Copy link
Contributor

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but can you use STA.empty instead of unsafeFreeze []?

@sharno
Copy link
Contributor Author

sharno commented Feb 12, 2019

Sure

hdgarrood
hdgarrood approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll merge in the next few days, unless anyone has any objections.

@garyb
Copy link
Member

garyb commented Mar 31, 2019

😁

@garyb garyb merged commit 83c2148 into purescript:master Mar 31, 2019
@hdgarrood
Copy link
Contributor

Oops - thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@hdgarrood hdgarrood hdgarrood approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharno @garyb @hdgarrood