Skip to content

Reverse the order of the arguments to \\ #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2014
Merged

Reverse the order of the arguments to \\ #10

merged 1 commit into from
May 30, 2014

Conversation

paf31
Copy link
Contributor

@paf31 paf31 commented May 30, 2014

@joneshf or @garyb Can you please review this?

@garyb
Copy link
Member

garyb commented May 30, 2014

Oops! I should have added something in core-tests for this.

👍

paf31 added a commit that referenced this pull request May 30, 2014
Reverse the order of the arguments to \\
@paf31 paf31 merged commit fc75a33 into master May 30, 2014
@paf31 paf31 deleted the fix-without branch May 30, 2014 15:08
@joneshf
Copy link
Member

joneshf commented May 31, 2014

Question about this, does tco not kick in for operators? It doesn't seem like there's any difference between \\ and go here.

@paf31
Copy link
Contributor Author

paf31 commented May 31, 2014

@joneshf It does, I just didn't realize that my changes made \\ and go equivalent :)

@garyb
Copy link
Member

garyb commented May 31, 2014

I think that was my mistake again actually, the original was tail recursive too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants