Skip to content

Conversation

@paluh
Copy link
Contributor

@paluh paluh commented Aug 31, 2016

No description provided.

@garyb
Copy link
Member

garyb commented Sep 12, 2016

I'll merge this along with the query-representation update when that arrives. 😉 It's perhaps minorly breaking since the show instances have changed (for the better).

Thanks!

@paluh
Copy link
Contributor Author

paluh commented Sep 16, 2016

I've changed query representation and fixed appropriate tests.

I only wonder If we want to differentiate between empty query (Just (Query Nil))) and completely missing query (Nothing)? Do you think that this difference could be semantically important?

@paluh
Copy link
Contributor Author

paluh commented Sep 16, 2016

I think that you should ignore my previous comment about query representation... I think that we really want to be exact here and reflect given url as close as possible in our values (so we want to catch this difference between missing and empty query). Am I right?

@garyb
Copy link
Member

garyb commented Sep 16, 2016

Yeah I think the distinction would be good to have. I'm not sure if semantically it would matter, but I guess the "visible" difference would be in the case of Just (Query Nil) you get a trailing ? on the URL.

@garyb garyb mentioned this pull request Oct 28, 2016
@garyb garyb merged commit fa045bf into purescript-contrib:master Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants