Skip to content

Added several methods #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Added several methods #20

wants to merge 2 commits into from

Conversation

@xgrommx
Copy link

@xgrommx xgrommx commented Jul 31, 2018

No description provided.

@garyb
Copy link
Member

garyb commented Jul 31, 2018

I'd prefer not to incur a dependency on purescript-filterable as it lives outside of -contrib, meaning it could potentially block updates to this.

@thomashoneyman
Copy link
Contributor

thomashoneyman commented Aug 19, 2019

@xgrommx Would you consider adjusting this to only include the improvements that don't rely on packages outside -contrib? In that case I can help push this along to get merged.

@thomashoneyman thomashoneyman changed the base branch from master to main September 12, 2020 01:23
@thomashoneyman thomashoneyman mentioned this pull request Sep 12, 2020
Merged
@thomashoneyman
Copy link
Contributor

thomashoneyman commented Sep 13, 2020

#25 applies these functions outside of the -filterable dependency, and without the additional functions from profunctor-lenses, but I'd be happy to merge anything adding the profunctor-lenses additions in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xgrommx @garyb @thomashoneyman