Skip to content

Children should be a ReactRender instance #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
natefaubion opened this issue Nov 27, 2017 · 2 comments
Closed

Children should be a ReactRender instance #127

natefaubion opened this issue Nov 27, 2017 · 2 comments

Comments

@natefaubion
Copy link
Contributor

Likewise, getChildren should just yield Children.
@unclechu
Copy link

Maybe this is related:

purescript-react/src/React.purs

Lines 415 to 417 in 14b4c22

createClassStateless' :: forall props render.
ReactRender render =>
(props -> Array ReactElement -> render) -> ReactClass props

Children here is Array ReactElement but maybe it should be another ReactRender instance?

@natefaubion natefaubion mentioned this issue Mar 4, 2018
Merged
@ethul
Copy link
Contributor

ethul commented Apr 14, 2018

Closing. Fixed via #137

@ethul ethul closed this as completed Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@natefaubion @ethul @unclechu