Fix warnings revealed by PureScript v0.14.1 #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purefunctor
commented
Apr 21, 2021
| , fromArray | ||
| , msplit | ||
| , interleave | ||
| , once |
There was a problem hiding this comment.
Quick question, where in the changelog should this change fall under?
There was a problem hiding this comment.
Good question. In one way, it's fixing a bug. In another, it's a new feature because it wasn't previously usable. I think it should at least go in New Features.
There was a problem hiding this comment.
You can add two changes — a bug fix for removing the warnings and a new feature for exporting a previously hidden function, both linking to this PR
There was a problem hiding this comment.
Sounds good, will do that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Links to purescript-contrib/governance#37
Checklist: