Skip to content

Loosen constraints on functions and instances #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 2, 2020
Merged

Loosen constraints on functions and instances #43

merged 5 commits into from
Oct 2, 2020

Conversation

triallax
Copy link
Contributor

@triallax triallax commented Oct 1, 2020 •
edited by thomashoneyman
Loading

Description of the change
Many functions and instances have overly specific constraints. This PR loosens many of them.

Fixes #42.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@triallax triallax marked this pull request as ready for review October 1, 2020 17:15
thomashoneyman
thomashoneyman reviewed Oct 1, 2020
View reviewed changes
@thomashoneyman thomashoneyman merged commit a1974c2 into purescript-contrib:main Oct 2, 2020
@triallax triallax deleted the loosen-constraints branch October 3, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomashoneyman thomashoneyman thomashoneyman left review comments

@paluh paluh paluh approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Monad constraint on f is unnecessarily powerful in many functions

3 participants

@triallax @paluh @thomashoneyman