-
Notifications
You must be signed in to change notification settings - Fork 6
Update according to Contributors library guidelines #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
a834754
3b7d09a
d3451e8
e7de50e
2aa2369
cfc9d6f
f38908a
70d0a17
badc0be
44359e9
aeaa973
8f1e01e
db38e68
93276ec
5d560a5
47532e5
4fb25cd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# https://editorconfig.org | ||
root = true | ||
|
||
[*] | ||
indent_style = space | ||
indent_size = 2 | ||
end_of_line = lf | ||
charset = utf-8 | ||
trim_trailing_whitespace = true | ||
insert_final_newline = true | ||
|
||
[*.md] | ||
trim_trailing_whitespace = false |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# Contributing to Http Methods | ||
|
||
Thanks for your interest in contributing to `http-methods`! We welcome new contributions regardless of your level of experience or familiarity with PureScript. | ||
|
||
Every library in the Contributors organization shares a simple handbook that helps new contributors get started. With that in mind, please [read the short contributing guide on purescript-contrib/governance](https://github.com/purescript-contrib/governance/blob/main/contributing.md) before contributing to this library. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
--- | ||
name: Bug report | ||
about: Report an issue | ||
title: "" | ||
labels: bug | ||
assignees: "" | ||
--- | ||
|
||
**Describe the bug** | ||
A clear and concise description of the bug. | ||
|
||
**To Reproduce** | ||
A minimal code example (preferably a runnable example on [Try PureScript](https://try.purescript.org)!) or steps to reproduce the issue. | ||
|
||
**Expected behavior** | ||
A clear and concise description of what you expected to happen. | ||
|
||
**Additional context** | ||
Add any other context about the problem here. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
--- | ||
name: Change request | ||
about: Propose an improvement to this library | ||
title: "" | ||
labels: "" | ||
assignees: "" | ||
--- | ||
|
||
**Is your change request related to a problem? Please describe.** | ||
A clear and concise description of the problem. | ||
|
||
Examples: | ||
|
||
- It's frustrating to have to [...] | ||
- I was looking for a function to [...] | ||
|
||
**Describe the solution you'd like** | ||
A clear and concise description of what a good solution to you looks like, including any solutions you've already considered. | ||
|
||
**Additional context** | ||
Add any other context about the change request here. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
blank_issues_enabled: false | ||
contact_links: | ||
- name: PureScript Discourse | ||
url: https://discourse.purescript.org/ | ||
about: Ask and answer questions here. | ||
- name: Functional Programming Slack | ||
url: https://functionalprogramming.slack.com | ||
about: For casual chat and questions (use https://fpchat-invite.herokuapp.com to join). |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
**Description of the change** | ||
Clearly and concisely describe the purpose of the pull request. If this PR relates to an existing issue or change proposal, please link to it. Include any other background context that would help reviewers understand the motivation for this PR. | ||
|
||
--- | ||
|
||
**Checklist:** | ||
|
||
- [ ] Added the change to the changelog's "Unreleased" section with a link to this PR and your username | ||
- [ ] Linked any existing issues or proposals that this pull request should close | ||
- [ ] Updated or added relevant documentation in the README and/or documentation directory | ||
- [ ] Added a test for the contribution (if applicable) |
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
name: CI | ||
|
||
on: | ||
push: | ||
branches: [main] | ||
pull_request: | ||
branches: [main] | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
|
||
- name: Set up a PureScript toolchain | ||
uses: purescript-contrib/setup-purescript@main | ||
|
||
- name: Cache PureScript dependencies | ||
uses: actions/cache@v2 | ||
with: | ||
key: ${{ runner.os }}-spago-${{ hashFiles('**/*.dhall') }} | ||
path: | | ||
.spago | ||
output | ||
|
||
- name: Install dependencies | ||
run: spago install | ||
|
||
- name: Build source | ||
run: spago build --no-install --purs-args '--censor-lib --strict' | ||
|
||
- name: Run tests | ||
run: spago test --no-install | ||
thomashoneyman marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
name: "Stale" | ||
|
||
on: | ||
schedule: | ||
- cron: "0 0 * * *" | ||
|
||
jobs: | ||
stale: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/stale@v3 | ||
env: | ||
days-until-stale: 60 | ||
days-until-close: 14 | ||
with: | ||
repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
stale-issue-message: "This issue is stale because it has been open for ${{ env.days-until-stale }} days with no activity. Remove the stale label or comment to keep this issue open. Otherwise, this issue will be closed in ${{ env.days-until-close }} days." | ||
stale-pr-message: "This pull request is stale because it has been open for ${{ env.days-until-stale }} days with no activity. Remove the stale label or comment to keep this pull request open. Otherwise, this pull request will be closed in ${{ env.days-until-close }} days." | ||
days-before-stale: ${{ env.days-until-stale }} | ||
days-before-close: ${{ env.days-until-close }} | ||
stale-issue-label: "stale" | ||
stale-pr-label: "stale" | ||
exempt-pr-labels: "breaking change" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,8 @@ | ||
/.* | ||
!/.gitignore | ||
!/.github | ||
!/.travis.yml | ||
.* | ||
!.gitignore | ||
!.github | ||
!.editorconfig | ||
|
||
# Dependencies | ||
bower_components | ||
node_modules | ||
|
||
# Generated files | ||
output | ||
generated-docs | ||
|
||
# Lockfiles | ||
package-lock.json | ||
*.lock | ||
bower_components |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,44 @@ | ||
# purescript-http-methods | ||
# Http Methods | ||
thomashoneyman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
[](https://github.com/purescript-contrib/purescript-http-methods/releases) | ||
[](https://travis-ci.org/purescript-contrib/purescript-http-methods) | ||
[](http://pursuit.purescript.org/packages/purescript-http-methods/) | ||
[](http://github.com/garyb) | ||
[](http://github.com/thomashoneyman) | ||
[](https://github.com/purescript-contrib/purescript-http-methods/actions?query=workflow%3ACI+branch%3Amain) | ||
[](https://github.com/purescript-contrib/purescript-http-methods/releases) | ||
[](https://pursuit.purescript.org/packages/purescript-http-methods) | ||
[](https://github.com/garyb) | ||
[](https://github.com/thomashoneyman) | ||
|
||
HTTP method type. | ||
|
||
## Installation | ||
|
||
Install `http-methods` with [Spago](https://github.com/purescript/spago): | ||
|
||
```sh | ||
spago install http-methods | ||
``` | ||
bower install purescript-http-methods | ||
``` | ||
|
||
## Quick start | ||
|
||
The quick start hasn't been written yet (contributions are welcome!). The quick start covers a common, minimal use case for the library, whereas longer examples and tutorials are kept in the [docs directory](./docs.) | ||
thomashoneyman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Documentation | ||
|
||
Module documentation is [published on Pursuit](http://pursuit.purescript.org/packages/purescript-http-methods). | ||
`http-methods` documentation is stored in a few places: | ||
|
||
1. Module documentation is [published on Pursuit](https://pursuit.purescript.org/packages/purescript-http-methods). | ||
2. Written documentation and [the changelog](./docs/CHANGELOG.md) are kept in [the docs directory](./docs). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If there's not much reason for a documentation directory we could perhaps just remove them and treat this as a special case. Perhaps we could add to the library summary the RFCs this is based on (HTTP/1.1 with RFC 2518 and RFC 5789)? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm up for removing the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like we do need to move the CHANGELOG and the CONTRIBUTING files into the repository root. When doing that, we could remove this line altogether (because there won't be a docs directory anymore). Remember that we'll also need to fix the CONTRIBUTING link later in the README file. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think leaving I think moving it to the root folder is better as it increases visibility of it. |
||
3. Usage examples can be found in [the test suite](./test). | ||
thomashoneyman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
If you get stuck, there are several ways to get help: | ||
|
||
- [Open an issue](https://github.com/purescript-contrib/purescript-http-methods/issues) if you have encountered a bug or problem. | ||
- [Search or start a thread on the PureScript Discourse](https://discourse.purescript.org) if you have general questions. You can also ask questions in the `#purescript` and `#purescript-beginners` channels on the [Functional Programming Slack](https://functionalprogramming.slack.com) ([invite link](https://fpchat-invite.herokuapp.com/)). | ||
|
||
## Contributing | ||
|
||
Read the [contribution guidelines](https://github.com/purescript-contrib/purescript-http-methods/blob/master/.github/contributing.md) to get started and see helpful related resources. | ||
You can contribute to `http-methods` in several ways: | ||
|
||
1. If you encounter a problem or have a question, please [open an issue](https://github.com/purescript-contrib/purescript-http-methods/issues). We'll do our best to work with you to resolve or answer it. | ||
|
||
2. If you would like to contribute code, tests, or documentation, please [read the contributor guide](./.github/CONTRIBUTING.md). It's a short, helpful introduction to contributing to this library, including development instructions. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to update this link to point at There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done! |
||
|
||
3. If you have written a library, tutorial, guide, or other resource based on this package, please share it on the [PureScript Discourse](https://discourse.purescript.org)! Writing libraries and learning resources are a great way to help this library succeed. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# Changelog | ||
|
||
Notable changes to this project are documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
||
## [Unreleased] | ||
|
||
Breaking changes (😱!!!): | ||
|
||
New features: | ||
|
||
Bugfixes: | ||
|
||
Other improvements: | ||
|
||
## [0.0.0] - 2020-01-01 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Http Methods Documentation | ||
thomashoneyman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
This directory contains documentation for `http-methods`. If you are interested in contributing new documentation, please read the [contributor guidelines](../.github/CONTRIBUTING.md) and [What Nobody Tells You About Documentation](https://documentation.divio.com) for help getting started. |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
let upstream = | ||
https://github.com/purescript/package-sets/releases/download/psc-0.13.8-20200911-2/packages.dhall sha256:872c06349ed9c8210be43982dc6466c2ca7c5c441129826bcb9bf3672938f16e | ||
|
||
in upstream |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ name = "http-methods" | ||
, dependencies = | ||
[ "console", "effect", "either", "prelude", "psci-support", "strings" ] | ||
, packages = ./packages.dhall | ||
, sources = [ "src/**/*.purs", "test/**/*.purs" ] | ||
} |
Uh oh!
There was an error while loading. Please reload this page.