Skip to content

Docs on contributing and releasing #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2022
Merged

Docs on contributing and releasing #152

merged 2 commits into from
Apr 5, 2022

Conversation

@genebean
Copy link
Contributor

@genebean genebean commented Oct 12, 2021 •
edited
Loading

Status

Ready for merge thanks to @yachub

Description

Update docs for contributing and releasing

Todos

  • Documentation

Reviewers

@puppetlabs/dio
@highb
@briancain

@genebean genebean changed the title ## Status Docs on contributing and releasing Oct 12, 2021
tanisha-payne
tanisha-payne reviewed Oct 12, 2021
View reviewed changes
Copy link
Contributor

@tanisha-payne tanisha-payne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful information! I wasn't sure how to submit a release!

highb
highb approved these changes Feb 6, 2022
View reviewed changes
Copy link
Contributor

@highb highb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray for GH actions! 🎉

@genebean
Copy link
Contributor Author

genebean commented Feb 7, 2022 •
edited
Loading

@yachub we should probably adjust this to be more like the workflow we have for other things in DIO... what do you think?

@yachub
Copy link

yachub commented Apr 5, 2022

@genebean Sounds good, I just changed the workflow to match what we user for vmpooler.

@yachub yachub force-pushed the reviews-and-releases branch from 5bb049c to 7f74035 Compare April 5, 2022 14:24
@yachub yachub marked this pull request as ready for review April 5, 2022 14:47
@yachub yachub requested a review from a team as a code owner April 5, 2022 14:47
@genebean
Copy link
Contributor Author

genebean commented Apr 5, 2022

LGTM, thanks @yachub for finishing this up.

sbeaulie
sbeaulie reviewed Apr 5, 2022
View reviewed changes
@yachub yachub force-pushed the reviews-and-releases branch from 7f74035 to 3e8ddca Compare April 5, 2022 15:38
@yachub yachub merged commit b84bc2b into main Apr 5, 2022
@yachub yachub deleted the reviews-and-releases branch April 5, 2022 15:39
yachub added a commit that referenced this pull request Apr 5, 2022
@yachub
v1.7.0 release prep
f74fe22 
Includes the following PRs since the last release:
- #157
- #160
- #159
- #155
- #152
- #158
@yachub yachub mentioned this pull request Apr 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@tanisha-payne tanisha-payne tanisha-payne left review comments

@highb highb highb approved these changes

@sbeaulie sbeaulie sbeaulie approved these changes

@yachub yachub yachub approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@genebean @yachub @highb @sbeaulie @tanisha-payne