Skip to content

declaring a symlink should not alter the default symlink to current module #397

@MartyEwings

Description

@MartyEwings

This code

fixtures['symlinks'] = auto_symlink if fixtures['symlinks'].nil?

prevents the use of symlinks section of the fixtures file for any other purpose than self reference for example:

symlinks:
peadm_spec: "#{source_dir}/spec/fixtures/modules/peadm/spec/acceptance/peadm_spec/"

would mean the code above would not also include this in the fixtures

symlinks:
<module_name>: "#{source_dir}"

It would be preferred if instead of a check and replace

fixtures['symlinks'] = auto_symlink if fixtures['symlinks'].nil?

that fixtures['symlinks'] wold be merged with auto_symlink to prevent loss of testing context

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions