Skip to content

(CAT-2228) Update legacy facts #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

(CAT-2228) Update legacy facts #650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/facter/vcsrepo_svn_ver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Facter.add(:vcsrepo_svn_ver) do
setcode do
if Facter.value(:operatingsystem) == 'Darwin' && !File.directory?(Facter::Core::Execution.execute('xcode-select -p'))
if Facter.value(:'os.name') == 'Darwin' && !File.directory?(Facter::Core::Execution.execute('xcode-select -p'))
''
else
version = Facter::Core::Execution.execute('svn --version --quiet')
Expand Down
2 changes: 1 addition & 1 deletion lib/puppet/provider/vcsrepo/dummy.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
desc 'Dummy default provider'

defaultfor feature: :posix
defaultfor operatingsystem: :windows
defaultfor 'os.name': :windows

def working_copy_exists?
providers = begin
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/facter/vcsrepo_svn_ver_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
describe 'vcsrepo_svn_ver' do
context 'with valid value' do
before :each do
allow(Facter.fact(:operatingsystem)).to receive(:value).and_return('OpenBSD')
allow(Facter.fact(:'os.name')).to receive(:value).and_return('OpenBSD')
allow(Facter::Core::Execution).to receive(:execute)
.with('svn --version --quiet')
.and_return('1.7.23')
Expand Down
Loading