Optimize var types

[Joris29]

Creating a PR to optimize some var types

Fixes #518

[CLAassistant]

All committers have signed the CLA.

[puppet-community-rangefinder]

tomcat::config::server is a type

Breaking changes to this file WILL impact these 2 modules (exact match):

• fervid-secure_tomcat_cis
• autostructure-secure_tomcat

Breaking changes to this file MAY impact these 2 modules (near match):

• Azcender-java_web_application_server
• autostructure-docker_tomcat_module

tomcat::install is a type

Breaking changes to this file WILL impact these 6 modules (exact match):

• slenky-guacamole
• jconway-opengrok
• fervid-secure_tomcat_cis
• autostructure-secure_tomcat
• factorit-jasperreports_server
• geoffwilliams-r_profile

Breaking changes to this file MAY impact these 1 modules (near match):

• soli-wrappers

This module is declared in 8 of 580 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[jordanbreen28]

Thanks for this @Joris29!
So the PR test failure was expected with the changing of data types & should be a simple fix. Can you run bundle exec puppet strings generate --format markdown --out REFERENCE.md

The spec test failures will be a bit more tricky, and look like the test cases will need amended or problems with the data types fixed to pass.

Appreciate the time you have spent on this!

[Joris29]

@jordanbreen28 Just to be clear should i also investigate the unit tests or will this be something done by you guys.
I'm more than happy to do it but just have to know don't want this to become a stale PR

[jordanbreen28]

@jordanbreen28 Just to be clear should i also investigate the unit tests or will this be something done by you guys. I'm more than happy to do it but just have to know don't want this to become a stale PR

Apologies @Joris29 I was out last week and missed this notification!
It would be best to try figure out the test failures yourself, as if left like this it for the team it would need to be properly prioritised and added to our backlog before being assigned out, which could be quite some time.

I am happy to collaborate with you and your efforts as you work on this (when you have the time of course)!

[Joris29]

Alright i will take a look when i have time

[Joris29]

Made some changes and i ran the tests locally and they seem fine

[Joris29]

@jordanbreen28 Could you have a look?
Unit tests seem ok.

[jordanbreen28]

@Joris29 so sorry I missed your ping!
Lets run the ci and see what happens

[jordanbreen28]

This is looking close to go..
Can you clean up your commits (remove the merge ones mainly) and rebase, then we should be good to merge!
Nice job on this one @Joris29 💯

[Joris29]

@jordanbreen28 I did rebase to one clean commit so i guess it's good to go :)

[jordanbreen28]

Great job @Joris29 - thanks for your work on this one..
I'll work to get this released this week.