Skip to content

fixed wrong comment in unixpath.pp #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2017
Merged

fixed wrong comment in unixpath.pp #862

merged 2 commits into from
Dec 11, 2017

Conversation

c33s
Copy link
Contributor

@c33s c33s commented Dec 5, 2017

@pegasd
Copy link
Contributor

pegasd commented Dec 5, 2017 •
edited
Loading

Should the contain a "." part be here?

@c33s
Copy link
Contributor Author

c33s commented Dec 6, 2017

oh this was a wrong assumption. i digged through an puppetlabs-lvm error to stdlib::absolutepath which is using unixpath. so a assumed it has to be a absolute unix path which also does not contain any relative parts (/home/../etc)

i remove the dots part from the PR

tested the regex with https://regex101.com/

is/should this be a valid unixpath?

/./......../'''ääÄÄÄvffoo/ü/:\\-__##../bar/com

@eputnam
Copy link
Contributor

eputnam commented Dec 6, 2017

That is a valid unix path, yes.

@tphoney
Copy link
Contributor

tphoney commented Dec 11, 2017

Thanks @c33s !

@tphoney tphoney merged commit c95ae34 into puppetlabs:master Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@c33s @pegasd @eputnam @tphoney @jordanbreen28