Addition of new length function #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
suggested changes
Mar 13, 2017
lib/puppet/functions/length.rb
Outdated
| #A function to eventually replace the old size() function for stdlib - The original size function did not handle Puppets new type capabilities, so this function is a Puppet 4 compatible solution. | ||
| Puppet::Functions.create_function(:length) do | ||
| dispatch :length do | ||
| param 'Any', :value |
There was a problem hiding this comment.
Using the proper type declaration here, using Variant, will avoid the need for the raise in L12 below.
Using the proper type declarations here, using different dispatches for Strings, and others, will avoid the need for the if chain in L7.
HelenCampbell
force-pushed
the
lengthfunct
branch
5 times, most recently
from
eb1741f to
0724ebe
Compare
HelenCampbell
force-pushed
the
lengthfunct
branch
from
0724ebe to
2d9a94e
Compare
|
Title needs changing, and still waiting for travis&appveyor |
HelenCampbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.