validate_integer, validate_numeric: explicitely reject hashes in arrays #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -109,6 +109,7 @@ module Puppet::Parser::Functions | |||
| # check every element of the array | |||
| input.each_with_index do |arg, pos| | |||
| begin | |||
| raise TypeError.new if arg.is_a?(Hash) | |||
There was a problem hiding this comment.
The .new shouldn't be necessary.
Without this patch, Ruby 1.8's Hash#to_s behaviour causes [{1=>2}] to be
treated as "12" when validating values.
|
Indeed, thanks for the hint. Also, rebased. |
|
This gave me a big belly laugh. Also +1. |
tphoney
added a commit
that referenced
this pull request
May 28, 2015
validate_integer, validate_numeric: explicitely reject hashes in arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, Ruby 1.8's Hash#to_s behaviour causes [{1=>2}] to be
treated as "12" when validating values.