Fix strict_variables = true

[bobtfish]

This makes things work for me if you have the strict_variables setting set to true.

[igalic]

But fails for everyone else now :(

[bobtfish]

hehe, damn, sorry - I'll loop back on this today, and see if I can get travis to like both types (and maybe even test both settings!)

[igalic]

Excellent. Now we only fail on Ruby 1.8, which seems to be a Travis issue.

[bobtfish]

Ping! Is there anything blocking this from being merged?

[bobtfish]

I've just rebased this to master

[spuder]

+1

To test this, I had to update my .fixtures.yaml

  repositories:
    stdlib: 
      repo: "git://github.com/bobtfish/puppetlabs-stdlib.git"
      ref: "origin/fix_strict_variables"
  symlinks:
    gitlab: "#{source_dir}"

Then run the following commands

export STRICT_VARIABLES=yes
rake spec_prep
rake spec

With this fix, spec tests no longer give errors if using a custom fact and strict variables are turned on
spuder/puppet-gitlab@e55560a

$local_operatingsystem_lowercase=getvar("::operatingsystem_lowercase")
$gitlab_url = "${download_prefix}/$local_operatingsystem_lowercase-${::operatingsystemrelease}/${omnibus_filename}"

[igalic]

@hunner ping

[bobtfish]

👍 thank you!