Implement the basename() function to stdlib. #274
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnlmengs
pushed a commit
to dnlmengs/puppetlabs-stdlib
that referenced
this pull request
Sep 24, 2014
…lement the basename() function to stdlib.): now admits removing file extension, the ruby File.basename() way
|
👍 |
| ) do |arguments| | ||
|
|
||
| raise(Puppet::ParseError, "basename(): Wrong number of arguments " + | ||
| "given (#{arguments.size} for 1)") if arguments.size < 1 |
There was a problem hiding this comment.
can you get rid of this, and instead use :arity, please?
see, #249
|
I just committed what you requested to drq883/puppetlabs-stdlib. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always wondered why basename() wasn't in stdlib since dirname() was.
We ended up writing our own locallib module to implement the basename() function to keep from having to write inline ruby code. We were working on a nfs mounting module and wanted to default to the basename of the filer's exported path to be the default mount point. This new function gives us that feature.
This is just a modification of the dirname.rb file where all references to dirname were replaced with basename. This same implementation in our locallib works fine.
I have also updated the spec/ files to behave as I think they should.
Thanks for considering this new function.