Modules 707 #262
Merged
Modules 707 #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like solid maintenance work -- many of the functions and their tests have been inconsistent in style for too long. 👍 The travis run was with puppet 3.6.1. I don't expect the type checking changes to break earlier versions of puppet but has this been tested with puppet < 3.5 ? |
|
They're running fine against 3.3 and 2.7.24 but I've not run test cases against anything less than 3.5 |
…ring We need to use unless value.is_a?(String) || value.is_a?(Array) rather than klass = value.class unless [String, Array].include?(klass) because the klass version enforces type checking which is too strict, and does not allow us to accept objects wich have extended String (or Array). For example, generate() function now returns Puppet::Util::Execution::ProcessOutput which is just a very simple extension of String. While this in it's self was not intentional (PUP-2306) it is not unreasonable to cope with objects which extend Strings
tremble
force-pushed
the
MODULES-707
branch
from
502a989 to
23bc7d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://tickets.puppetlabs.com/browse/MODULES-707
Re-use existing str2bool code rather than doing a copy and paste.
Be slightly more relaxed about accepting objects which extend string/array rather than only allowing String/Array