(#20200) Add a recursive merge function. #189
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #20200 notes that the merge function does not support nested hashes. To prevent unintended side effects with changing merge, add a deep_merge function instead.
|
After chatting with Adrien, I made a few changes to pull in the overlay function as a Proc and simplify the merging decisions based on Hash.merge's block variant which will execute the passed block when keys conflict. This has been merged to master and should be part of the next 4.x release. |
wmfgerrit
pushed a commit
to wikimedia/operations-puppet
that referenced
this pull request
Mar 23, 2016
Import the #189 PR of puppetlabs-stdlib to add the deep_merge function puppetlabs/puppetlabs-stdlib#189. It is a variant of the merge function that we already have in our repo. It is done as a solo commit, instead of fully upgrading our stdlib version to the one by puppetlabs in order to avoid any unforeseen consequences to other users of stdlib in our repo. Change-Id: Iddd0b869b1c55197d5e7436bdab8bac67cbf5d06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per puppetlabs/puppetlabs-mysql#274 and for issue #20200 I am adding a recursive merge function to stdlib. Since replacing the normal merge with this new functionality can cause unexpected consequences, this is being added as a new function (deep_merge).
This is replacing the original pull request #186 and moving it to my github organization that has signed the CLA. The other issues have also been resolved.