Skip to content

(#16498) Added unit test for loadyaml function. #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2013

Conversation

lmello
Copy link
Contributor

@lmello lmello commented Sep 17, 2013

As stated on the issue #16498, it would be great to have unit tests
for all the functions.

Function loadyaml was missing a unit test. This commit added the
unit test to loadyaml function.

@@ -0,0 +1,26 @@
#! /usr/bin/env ruby -S rspec
require 'spec_helper'
require 'fileutils'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the fileutils module actually used in this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it isn't. i had removed it.

@adrienthebo
Copy link
Contributor

Thank you very much for this contribution! This looks pretty good, I just have one question that I've added inline. Otherwise this is great, we should have it merged shortly!

As stated on the issue #16498, it would be great to have unit tests
for all the functions.

Function loadyaml was missing a unit test. This commit added the
unit test to loadyaml function.
@lmello
Copy link
Contributor Author

lmello commented Sep 17, 2013

Thanks for the comments.

I had removed the require 'fileutils' since it is not required.

best

@adrienthebo
Copy link
Contributor

Thanks for addressing the fileutils question, I know it is a very small detail but it helps to address these questions up front. :)

adrienthebo added a commit that referenced this pull request Sep 17, 2013
(#16498) Added unit test for loadyaml function.
@adrienthebo adrienthebo merged commit f7f70fe into puppetlabs:master Sep 17, 2013
@adrienthebo
Copy link
Contributor

summary: merged into master in f7f70fe; thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants