(#16498) Added unit test for loadyaml function. #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,26 @@ | |||
| #! /usr/bin/env ruby -S rspec | |||
| require 'spec_helper' | |||
| require 'fileutils' | |||
There was a problem hiding this comment.
Is the fileutils module actually used in this file?
There was a problem hiding this comment.
no it isn't. i had removed it.
|
Thank you very much for this contribution! This looks pretty good, I just have one question that I've added inline. Otherwise this is great, we should have it merged shortly! |
As stated on the issue #16498, it would be great to have unit tests for all the functions. Function loadyaml was missing a unit test. This commit added the unit test to loadyaml function.
|
Thanks for the comments. I had removed the require 'fileutils' since it is not required. best |
|
Thanks for addressing the fileutils question, I know it is a very small detail but it helps to address these questions up front. :) |
adrienthebo
added a commit
that referenced
this pull request
Sep 17, 2013
(#16498) Added unit test for loadyaml function.
|
summary: merged into master in f7f70fe; thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated on the issue #16498, it would be great to have unit tests
for all the functions.
Function loadyaml was missing a unit test. This commit added the
unit test to loadyaml function.