os_version_gte: fix and add tests #1206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in <puppetlabs#972 (comment)>, os_version_gte is not returning correct results. This commit fixes the tests to demonstrate correct expected behavior.
kenyon
force-pushed
the
fix_os_version_gte
branch
from
8569a61 to
d41611b
Compare
kenyon
added a commit
to kenyon/puppetlabs-stdlib
that referenced
this pull request
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #972 (comment),
os_version_gteis not returning correct results. This commit fixes the tests to demonstrate correct expected behavior.The tests are expected to fail.