Skip to content

stdlib::end_with: create String.end_with function #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2020
Merged

stdlib::end_with: create String.end_with function #1084

merged 1 commit into from
Feb 10, 2020

Conversation

b4ldr
Copy link
Collaborator

@b4ldr b4ldr commented Feb 5, 2020

This PR wraps the ruby String.end_with? function and exposes it to the
puppet DSL.

@b4ldr b4ldr requested a review from a team as a code owner February 5, 2020 16:58
@b4ldr b4ldr changed the title wmflib::end_with: create String.end_with function stdlib::end_with: create String.end_with function Feb 5, 2020
@b4ldr
Copy link
Collaborator Author

b4ldr commented Feb 5, 2020

looks like the CI checks stalled and may need kicking

@b4ldr
wmflib::end_with: create String.end_with function
44d32d2 
This PR wraps the ruby `String.end_with?` function and exposes it to the
puppet DSL.
@carabasdaniel
Copy link
Contributor

Hi @b4ldr
This looks good, thank you for your contribution.

@carabasdaniel carabasdaniel merged commit ade894a into puppetlabs:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b4ldr @carabasdaniel