Skip to content

(MODULES-9432) Remove Style/HashSyntax rubocop rule #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

eimlav
Copy link
Contributor

@eimlav eimlav commented Jun 20, 2019

This rule is used to enforce pre Ruby 1.9 hash syntax:

{:a => 2}

Since the module no longer supports Puppet versions which correspond
with anything pre Ruby 1.9, this should be removed to enforce the modern
hash syntax:

{a: 2, b: 1}

This rule is used to enforce pre Ruby 1.9 hash syntax:

	{:a => 2}

Since the module no longer supports Puppet versions which correspond
with anything pre Ruby 1.9, this should be removed to enforce the modern
hash syntax:

	{a: 2, b: 1}
@joshcooper
Copy link
Contributor

I don't think we should do this, because puppetserver 5.x uses JRuby 1.7 which is language compatible with MRI 1.9. So installing this module on puppetserver 5/PE 2018.1 will cause compilation to fail. See alsoMODULES-6139 and MODULES-8695

@eimlav
Copy link
Contributor Author

eimlav commented Jun 24, 2019

Hi @joshcooper thanks for the info. For now I'll disable the rule in the affected block in #1031 and we can look at this issue another time. Cheers.

@eimlav eimlav closed this Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants