Skip to content

Add check for invalid combinination of check_policy and check_expiration #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2014
Merged

Add check for invalid combinination of check_policy and check_expiration #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions manifests/login.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@

validate_re($login_type,['^(SQL_LOGIN|WINDOWS_LOGIN)$'])

if $check_expiration and !$check_policy {
fail ('Can not have check expiration enabled when check_policy is disabled')
}

$create_delete = $ensure ? {
present => 'create',
absent => 'delete',
Expand Down
5 changes: 5 additions & 0 deletions spec/defines/login_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,9 @@
it_behaves_like 'mssql_tsql command'
it_behaves_like 'mssql_tsql onlyif'
end
describe 'check_policy' do
let(:additional_params) { {:check_policy => false, :check_expiration => true} }
let(:raise_error_check) { 'Can not have check expiration enabled when check_policy is disabled' }
it_should_behave_like 'validation error'
end
end