(CAT-1148) Conversion of ERB to EPP #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramesh7
reviewed
Aug 25, 2023
Ramesh7
previously approved these changes
Aug 25, 2023
praj1001
force-pushed
the
CAT-1148-conversion_erb_to_epp
branch
from
ed0adb5 to
172b8a9
Compare
|
one thing I'd say is i'd consider this more of a feature than a bugfix for two reasons:
|
agreed with you @jordanbreen28, thanks for noticing it. Updated label. |
Ramesh7
approved these changes
Aug 25, 2023
jordanbreen28
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Conversion of ERB templates to EPP for sqlserver module.
Additional Context
Related Issues (if any)
Checklist
puppet apply)