(FM-8199) - Port module to Litmus

.fixtures.yml

@@ -1,5 +1,8 @@
 fixtures:
   repositories:
-    "stdlib": "https://github.com/puppetlabs/puppetlabs-stdlib.git"
+    facts: 'https://github.com/puppetlabs/puppetlabs-facts.git'
+    puppet_agent: 'https://github.com/puppetlabs/puppetlabs-puppet_agent.git'
+    provision: 'https://github.com/puppetlabs/provision.git'
+    stdlib: 'https://github.com/puppetlabs/puppetlabs-stdlib.git'
   symlinks:
     sqlserver: "#{source_dir}"

.github/workflows/release.yml

@@ -0,0 +1,81 @@
+
+name: "release"
+
+on: 
+  push:
+    branches:
+      - 'release'
+
+jobs:
+  LitmusAcceptance2012Sql:
+    runs-on: self-hosted
+    strategy:
+      matrix:
+        ruby_version: [2.5.x]
+        puppet_gem_version: [~> 6.0]
+        platform: [release_checks_sql_2012]
+        agent_family: ['puppet5', 'puppet6']
+
+    steps:
+    - uses: actions/checkout@v1
+    - name: Litmus Parallel
+      uses: puppetlabs/action-litmus_parallel@master
+      with:
+        platform: ${{ matrix.platform }}
+        agent_family: ${{ matrix.agent_family }}
+        additional_command: ${{ matrix.additional_command }}
+  LitmusAcceptance2014Sql:
+    runs-on: self-hosted
+    strategy:
+      matrix:
+        ruby_version: [2.5.x]
+        puppet_gem_version: [~> 6.0]
+        platform: [release_checks_sql_2014]
+        agent_family: ['puppet5', 'puppet6']
+
+    steps:
+    - uses: actions/checkout@v1
+    - name: Litmus Parallel
+      uses: puppetlabs/action-litmus_parallel@master
+      with:
+        platform: ${{ matrix.platform }}
+        agent_family: ${{ matrix.agent_family }}
+        additional_command: ${{ matrix.additional_command }}
+  LitmusAcceptance2016Sql:
+    runs-on: self-hosted
+    strategy:
+      matrix:
+        ruby_version: [2.5.x]
+        puppet_gem_version: [~> 6.0]
+        platform: [release_checks_sql_2016_parity]
+        agent_family: ['puppet5', 'puppet6']
+        additional_command: ['bundle exec rake litmus:add_feature[sqlversion_2016]']
+
+    steps:
+    - uses: actions/checkout@v1
+    - name: Litmus Parallel
+      uses: puppetlabs/action-litmus_parallel@master
+      with:
+        platform: ${{ matrix.platform }}
+        agent_family: ${{ matrix.agent_family }}
+        additional_command: ${{ matrix.additional_command }}
+
+  Spec:
+    runs-on: self-hosted
+    strategy:
+      matrix:
+        check: [parallel_spec, 'syntax lint metadata_lint check:symlinks check:git_ignore check:dot_underscore check:test_file rubocop']
+        ruby_version: [2.5.x]
+        puppet_gem_version: [~> 5.0, ~> 6.0]
+        exclude:
+        - puppet_gem_version: ~> 5.0
+          check: 'syntax lint metadata_lint check:symlinks check:git_ignore check:dot_underscore check:test_file rubocop'
+        - ruby_version: 2.5.x
+          puppet_gem_version: ~> 5.0
+    steps:
+    - uses: actions/checkout@v1
+    - name: Spec Tests
+      uses: puppetlabs/action-litmus_spec@master
+      with:
+        puppet_gem_version: ${{ matrix.puppet_gem_version }}
+        check: ${{ matrix.check }}

.sync.yml

@@ -31,20 +31,6 @@ appveyor.yml:
     CHECK: parallel_spec
   simplecov: true
 Gemfile:
-  required:
-    ":system_tests":
-    - gem: puppet-module-posix-system-r#{minor_version}
-      platforms: ruby
-    - gem: puppet-module-win-system-r#{minor_version}
-      platforms:
-      - mswin
-      - mingw
-      - x64_mingw
-    - gem: beaker-testmode_switcher
-      version: "~> 0.4"
-    - gem: master_manipulator
-    - gem: puppet-blacksmith
-      version: "~> 3.4"
   optional:
     ":development":
     - gem: ruby-pwsh

Gemfile

@@ -31,13 +31,6 @@ group :development do
   gem "ruby-pwsh",                                               require: false
   gem "github_changelog_generator",                              require: false, git: 'https://github.com/skywinder/github-changelog-generator', ref: '20ee04ba1234e9e83eb2ffb5056e23d641c7a018' if Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new('2.2.2')
 end
-group :system_tests do
-  gem "puppet-module-posix-system-r#{minor_version}", require: false, platforms: [:ruby]
-  gem "puppet-module-win-system-r#{minor_version}",   require: false, platforms: [:mswin, :mingw, :x64_mingw]
-  gem "beaker-testmode_switcher", '~> 0.4',           require: false
-  gem "master_manipulator",                           require: false
-  gem "puppet-blacksmith", '~> 3.4',                  require: false
-end
 
 puppet_version = ENV['PUPPET_GEM_VERSION']
 facter_version = ENV['FACTER_GEM_VERSION']

lib/puppet_x/sqlserver/sql_connection.rb

@@ -1,110 +1,112 @@
-module PuppetX::Sqlserver
-  CONNECTION_CLOSED = 0
-
-  class SqlConnection # rubocop:disable Style/Documentation
-    def open_and_run_command(query, config)
-      begin
-        open(config)
-        execute(query)
-      rescue win32_exception => e
-        return ResultOutput.new(true, e.message, @connection)
-      ensure
-        close
+module PuppetX # rubocop:disable Style/ClassAndModuleChildren
+  module Sqlserver
+    CONNECTION_CLOSED = 0
+
+    class SqlConnection # rubocop:disable Style/Documentation
+      def open_and_run_command(query, config)
+        begin
+          open(config)
+          execute(query)
+        rescue win32_exception => e
+          return ResultOutput.new(true, e.message, @connection)
+        ensure
+          close
+        end
+
+        ResultOutput.new(false, nil, @connection)
       end
 
-      ResultOutput.new(false, nil, @connection)
-    end
-
-    private
-
-    def connection
-      @connection ||= create_connection
-    end
+      private
 
-    def open(config)
-      connection_string = get_connection_string(config)
-      connection.Open(connection_string) if connection_closed?
-    end
-
-    def get_connection_string(config)
-      params = {
-        'Provider'             => 'SQLNCLI11',
-        'Initial Catalog'      => config[:database] || 'master',
-        'Application Name'     => 'Puppet',
-        'Data Source'          => '.',
-        'DataTypeComptibility' => 80,
-      }
-
-      admin_user = config[:admin_user] || ''
-      admin_pass = config[:admin_pass] || ''
-
-      if config[:admin_login_type] == 'WINDOWS_LOGIN'
-        # Windows based authentication
-        raise ArgumentError, _('admin_user must be empty or nil') unless admin_user == ''
-        raise ArgumentError, _('admin_pass must be empty or nil') unless admin_pass == ''
-        params.store('Integrated Security', 'SSPI')
-      else
-        # SQL Server based authentication
-        raise ArgumentError, _('admin_user must not be empty or nil') unless admin_user != ''
-        raise ArgumentError, _('admin_pass must not be empty or nil') unless admin_pass != ''
-        params.store('User ID',  admin_user)
-        params.store('Password', admin_pass)
+      def connection
+        @connection ||= create_connection
       end
 
-      if !config[:instance_name].nil? && config[:instance_name] !~ %r{^MSSQLSERVER$}
-        params['Data Source'] = ".\\#{config[:instance_name]}"
+      def open(config)
+        connection_string = get_connection_string(config)
+        connection.Open(connection_string) if connection_closed?
       end
 
-      params.map { |k, v| "#{k}=#{v}" }.join(';')
-    end
+      def get_connection_string(config)
+        params = {
+          'Provider'             => 'SQLNCLI11',
+          'Initial Catalog'      => config[:database] || 'master',
+          'Application Name'     => 'Puppet',
+          'Data Source'          => '.',
+          'DataTypeComptibility' => 80,
+        }
+
+        admin_user = config[:admin_user] || ''
+        admin_pass = config[:admin_pass] || ''
+
+        if config[:admin_login_type] == 'WINDOWS_LOGIN'
+          # Windows based authentication
+          raise ArgumentError, _('admin_user must be empty or nil') unless admin_user == ''
+          raise ArgumentError, _('admin_pass must be empty or nil') unless admin_pass == ''
+          params.store('Integrated Security', 'SSPI')
+        else
+          # SQL Server based authentication
+          raise ArgumentError, _('admin_user must not be empty or nil') unless admin_user != ''
+          raise ArgumentError, _('admin_pass must not be empty or nil') unless admin_pass != ''
+          params.store('User ID',  admin_user)
+          params.store('Password', admin_pass)
+        end
+
+        if !config[:instance_name].nil? && config[:instance_name] !~ %r{^MSSQLSERVER$}
+          params['Data Source'] = ".\\#{config[:instance_name]}"
+        end
+
+        params.map { |k, v| "#{k}=#{v}" }.join(';')
+      end
 
-    def close
-      connection.Close unless connection_closed?
-    rescue win32_exception # rubocop:disable Lint/HandleExceptions
-    end
+      def close
+        connection.Close unless connection_closed?
+      rescue win32_exception # rubocop:disable Lint/HandleExceptions
+      end
 
-    def connection_closed?
-      connection.State == CONNECTION_CLOSED
-    end
+      def connection_closed?
+        connection.State == CONNECTION_CLOSED
+      end
 
-    def create_connection
-      require 'win32ole'
-      WIN32OLE.new('ADODB.Connection')
-    end
+      def create_connection
+        require 'win32ole'
+        WIN32OLE.new('ADODB.Connection')
+      end
 
-    def execute(sql)
-      connection.Execute(sql, nil, nil)
-    end
+      def execute(sql)
+        connection.Execute(sql, nil, nil)
+      end
 
-    def parse_column_names(result)
-      result.Fields.extend(Enumerable).map(&:Name)
-    end
+      def parse_column_names(result)
+        result.Fields.extend(Enumerable).map(&:Name)
+      end
 
-    # having as a method instead of hard coded allows us to stub and test outside of Windows
-    def win32_exception
-      ::WIN32OLERuntimeError
+      # having as a method instead of hard coded allows us to stub and test outside of Windows
+      def win32_exception
+        ::WIN32OLERuntimeError
+      end
     end
-  end
 
-  class ResultOutput # rubocop:disable Style/Documentation
-    attr_reader :exitstatus, :error_message
+    class ResultOutput # rubocop:disable Style/Documentation
+      attr_reader :exitstatus, :error_message
 
-    def initialize(has_errors, error_message, connection)
-      @exitstatus = has_errors ? 1 : 0
+      def initialize(has_errors, error_message, connection)
+        @exitstatus = has_errors ? 1 : 0
 
-      @error_message = extract_messages(connection) || error_message
-    end
+        @error_message = extract_messages(connection) || error_message
+      end
 
-    def extract_messages(connection)
-      return nil if connection.nil? || connection.Errors.count.zero?
+      def extract_messages(connection)
+        return nil if connection.nil? || connection.Errors.count.zero?
 
-      error_count = connection.Errors.count - 1
+        error_count = connection.Errors.count - 1
 
-      ((0..error_count).map { |i| connection.Errors(i).Description.to_s }).join("\n")
-    end
+        ((0..error_count).map { |i| connection.Errors(i).Description.to_s }).join("\n")
+      end
 
-    def has_errors # rubocop:disable Style/PredicateName
-      @exitstatus != 0
+      def has_errors # rubocop:disable Style/PredicateName
+        @exitstatus != 0
+      end
     end
   end
 end

provision.yaml

@@ -0,0 +1,31 @@
+default:
+  provisioner: vagrant
+  images: ['gusztavvargadr/windows-server']
+release_checks_sql_2012:
+  provisioner: vmpooler
+  images: ['win-2012r2-x86_64']
+  vars: 'sqlversion: sqlserver_2012'
+release_checks_sql_2014_parity:
+  provisioner: vmpooler
+  images: ['win-2012r2-x86_64']
+  vars: 'sqlversion: sqlserver_2014'
+release_checks_sql_2014:
+  provisioner: vmpooler
+  images: ['win-2012r2-x86_64', 'win-2016-x86_64', 'win-2019-x86_64']
+  vars: 'sqlversion: sqlserver_2014'
+release_checks_sql_2016_parity:
+  provisioner: vmpooler
+  images: ['win-2012r2-x86_64', 'win-2016-x86_64']
+  vars: 'sqlversion: sqlserver_2016'
+release_checks_sql_2016:
+  provisioner: vmpooler
+  images: ['win-2012r2-x86_64', 'win-2016-x86_64', 'win-2019-x86_64']
+  vars: 'sqlversion: sqlserver_2016'
+release_checks_sql_2017:
+  provisioner: vmpooler
+  images: ['win-2012r2-x86_64', 'win-2016-x86_64', 'win-2019-x86_64']
+  vars: 'sqlversion: sqlserver_2017'
+release_checks_sql_2019:
+  provisioner: vmpooler
+  images: ['win-2012r2-x86_64', 'win-2016-x86_64', 'win-2019-x86_64']
+  vars: 'sqlversion: sqlserver_2019'