(MAINT) Increase timeout interval #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wait parameter in the start_sql_agent_job depends on a sleep interval that waits long enough for the agent to spool up a job and get it running. In testing it appears that some agent jobs are not spinning up fast enough, causing the wait parameter to have no effect. This change increased the timeout so that the wait parameter has time to see the job starting to execute and then wait for it to complete.
RandomNoun7
force-pushed
the
maint/increase-sleep-interval
branch
from
2284503 to
a948f7a
Compare
ThoughtCrhyme
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wait parameter in the start_sql_agent_job depends on a sleep
interval that waits long enough for the agent to spool up a job and get
it running.
In testing it appears that some agent jobs are not spinning up fast
enough, causing the wait parameter to have no effect. This change
increased the timeout so that the wait parameter has time to see the
job starting to execute and then wait for it to complete.