(MAINT) Increase timeout interval

RandomNoun7 · RandomNoun7 · commit 2284503c0b2b · 2019-03-22T15:01:02.000-07:00
The wait parameter in the start_sql_agent_job depends on a sleep
interval that waits long enough for the agent to spool up a job and get
it running.

In testing it appears that some agent jobs are not spinning up fast
enough, causing the wait parameter to have no effect. This change
increased the timeout so that the wait parameter has time to see the
job starting to execute and then wait for it to complete.
diff --git a/tasks/start_sql_agent_job.ps1 b/tasks/start_sql_agent_job.ps1
@@ -81,7 +81,7 @@ foreach ($instance in $SQLInstances) {
             $selectedJob.start($jobName)
             # It takes the server a little time to spin up the job. If we don't do this here
             # then the -wait parameter may not work later.
-            Start-Sleep -Milliseconds 300
+            Start-Sleep -Seconds 1
         }
     }
 }
@@ -96,6 +96,7 @@ do {
         }
         [void]$finishedJobs.add((New-CustomJobObject -job $job))
     }
+    Start-Sleep -Milliseconds 300
 } while ($wait -and !$done)
 
 $return.jobs = $finishedJobs

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ foreach ($instance in $SQLInstances) {`
`81`	`81`	`$selectedJob.start($jobName)`
`82`	`82`	`# It takes the server a little time to spin up the job. If we don't do this here`
`83`	`83`	`# then the -wait parameter may not work later.`
`84`		`- Start-Sleep -Milliseconds 300`
	`84`	`+ Start-Sleep -Seconds 1`
`85`	`85`	`}`
`86`	`86`	`}`
`87`	`87`	`}`
`@@ -96,6 +96,7 @@ do {`
`96`	`96`	`}`
`97`	`97`	`[void]$finishedJobs.add((New-CustomJobObject -job $job))`
`98`	`98`	`}`
	`99`	`+ Start-Sleep -Milliseconds 300`
`99`	`100`	`} while ($wait -and !$done)`
`100`	`101`
`101`	`102`	`$return.jobs = $finishedJobs`