(MODULES-5126) Puppet4ing SQL Server #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Stdlib library from version 4.13.1 onwards is required for Puppet 4 compatibility. This commit updates the metadata.json to enforce the correct module version.
glennsarti
changed the title
|
ping @HelenCampbell . This is my WIP PR for Puppet 4ing SQL Server. Would appreciate any pointers/feedback on my efforts so far. |
| if $trustworthy { sqlserver_validate_on_off($trustworthy) } | ||
| sqlserver_validate_range($two_digit_year_cutoff, 1753, 9999, | ||
| "Two digit year cutoff must be between 1753 and 9999, you provided ${two_digit_year_cutoff}") | ||
| if $log_filename or $log_filegrowth or $log_maxsize or $log_name or $log_size { |
There was a problem hiding this comment.
If either all or none of these need specified is there any point of doing the assertions on line 139-145 or 128-133? Instead of just catching them here?
| @@ -62,6 +62,7 @@ def convert_to_regexp(str) | |||
| shared_examples 'validation error' do | |||
| it { | |||
| params.merge!(additional_params) | |||
| #require 'pry'; binding.pry | |||
There was a problem hiding this comment.
Yeah...still a WIP
Previously this module used a lot of validation functions from stdlib which are now deprecated due to Puppet 4 Data types. This commit: - Converts all manifest type resources to use Puppet 4 Data Types - Removes any validation that is redundant due to using Data types - Removes the sqlserver_validate_on_off function as it is no longer required - Updates tests with different error messages due to Data Types
The sqlserver_validate_svrroles_hash function is no longer called and can be removed. This commit removes the function and its associated tests.
glennsarti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Stdlib library from version 4.13.1 onwards is required for Puppet 4
compatibility. This commit updates the metadata.json to enforce the correct
module version.
Previously this module used a lot of validation functions from stdlib which are
now deprecated due to Puppet 4 Data types. This commit:
The sqlserver_validate_svrroles_hash function is no longer called and can be
removed. This commit removes the function and its associated tests.