(FM-5062) Add testmode switcher to sqlserver module #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
reviewed
Jun 22, 2017
| gem "beaker-hostgenerator", *location_for(ENV['BEAKER_HOSTGENERATOR_VERSION']) | ||
| gem "beaker-abs", *location_for(ENV['BEAKER_ABS_VERSION'] || '~> 0.1') | ||
| gem "beaker-abs", *location_for(ENV['BEAKER_ABS_VERSION'] || '~> 0.1') | ||
| gem "beaker-testmode_switcher", '<= 0.2.0', :require => false |
Contributor
There was a problem hiding this comment.
These changes will need to go into sync.yaml otherwise the next modsync will overwrite them
| end | ||
|
|
||
| it "Validate new login and database actualy created" do | ||
| binding.pry |
Contributor
Author
There was a problem hiding this comment.
I thought I fixed this...
spec/spec_helper_acceptance.rb
Outdated
| # Install test helper modules onto agent. | ||
| %w(puppetlabs-mount_iso cyberious-pget).each do |dep| | ||
| on(agent, puppet("module install #{dep}")) | ||
| on(master, puppet("module install #{dep}")) |
Contributor
There was a problem hiding this comment.
These dependencies are agent only, not master. Is that an issue here?
Contributor
Author
There was a problem hiding this comment.
Investigating this...
glennsarti
approved these changes
Jun 23, 2017
Contributor
glennsarti
left a comment
glennsarti
left a comment
There was a problem hiding this comment.
LGTM once the SQL Server pipelines are ready for testmode switcher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.