Skip to content

(MODULES-3256)(MODULES-2323)(MODULES-2554)(MODULES-3083) Fix sqlserver::login resource #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 16, 2016
Merged

(MODULES-3256)(MODULES-2323)(MODULES-2554)(MODULES-3083) Fix sqlserver::login resource #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b724eca
(MODULES-3256) Fix create/delete of Windows based logins
glennsarti Aug 11, 2016
0965312
(MODULES-2323) Fix deleting an SQL login
glennsarti Aug 12, 2016
81886e0
(MODULES-2554) Fix remove database
glennsarti Aug 12, 2016
16c3668
(MODULES-3256) Refactor sqlserver_login_spec acceptance test
glennsarti Aug 12, 2016
98fc287
(MODULES-3256) Fix creating a login resource with additional attributes
glennsarti Aug 16, 2016
102185b
(MODULES-3083) Fix modifying server roles for an existing login
glennsarti Aug 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions spec/acceptance/sqlserver_database_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@ def run_sql_query_opts (query, expected_row_count)
end

after(:each) do

# delete created database:

pp = <<-MANIFEST
sqlserver::config{'MSSQLSERVER':
admin_user => 'sa',
Expand All @@ -41,8 +39,7 @@ def run_sql_query_opts (query, expected_row_count)
ensure => 'absent',
}
MANIFEST
#comment out the below line because of ticket MODULES-2554.
#ensure_sqlserver_database(host, pp)
ensure_sqlserver_database(host, pp)
end

it "Test Case C89019: Create a database" do
Expand All @@ -67,6 +64,37 @@ def run_sql_query_opts (query, expected_row_count)
run_sql_query(host, run_sql_query_opts(query, 1))
end

it "Delete a database" do
pp = <<-MANIFEST
sqlserver::config{'MSSQLSERVER':
admin_user => 'sa',
admin_pass => 'Pupp3t1@',
}
sqlserver::database{'#{@db_name}':
}
MANIFEST
ensure_sqlserver_database(host, pp)

puts "Validate the Database '#{@db_name}' exists"
query = "SELECT database_id from sys.databases WHERE name = '#{@db_name}';"
run_sql_query(host, run_sql_query_opts(query, 1))

pp = <<-MANIFEST
sqlserver::config{'MSSQLSERVER':
admin_user => 'sa',
admin_pass => 'Pupp3t1@',
}
sqlserver::database{'#{@db_name}':
ensure => absent,
}
MANIFEST
ensure_sqlserver_database(host, pp)

puts "Validate the Database '#{@db_name}' does not exist"
query = "SELECT database_id from sys.databases WHERE name = '#{@db_name}';"
run_sql_query(host, run_sql_query_opts(query, 0))
end

Copy link
Contributor

@ferventcoder ferventcoder Aug 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some new tests. Test coverage++ 👍

it "Test Case C89076: Create database with optional collation_name" do
pp = <<-MANIFEST
sqlserver::config{'MSSQLSERVER':
Expand Down
Loading