(FM-3655) SQL Server CI acceptance issues #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
cyberious
added a commit
that referenced
this pull request
Sep 14, 2015
…e_issues (FM-3655) SQL Server CI acceptance issues
| ensure_sqlserver_database(host, 'absent') | ||
| # remove the newly created database | ||
| # Temporarily skip delete database because of MODULES-2554 | ||
| #ensure_sqlserver_database(host, 'absent') |
There was a problem hiding this comment.
This is probably OK now - but cleanup might be necessary if the suite size grows / too many temporary databases are created.
There was a problem hiding this comment.
It would have been nice to emit a warning here as well that the suite has orphaned a database @phongdly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, database name is a constant value and with the pending issue of unable to delete database (ticket MODULES-2554), only one database has been used in several tests. This cause the test CI failed.
This PR removes all constants and replaced them by variables, commenting out dead codes, and temporarily skip delete/absent database in each test script (because of MODULES-2554 as mentioned above)