(MODULES-2497) SQLSERVER - Create Automated Tests for sqlserver::login #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(MODULES-2497) updated PR based on ticket FM-3655
phongdly
force-pushed
the
MODULES-2497/automated_test_for_sqlserver-login
branch
from
f15af7c to
a08c499
Compare
| } | ||
| end | ||
|
|
||
| context "Start testing...", {:testrail => ['89118', '89119', '89120', '89121', '89122', '89123', '89124', '89125', '891540']} do |
There was a problem hiding this comment.
Test case ID 891540 should be 89540.
There was a problem hiding this comment.
fixed in the next push
|
@phongdly Do you wait until automated tests are merged before marking the tests as "Automated" in TestRail? |
| } | ||
| MANIFEST | ||
| #comment out the below line because of ticket MODULES-2554(delete database) | ||
| #ensure_manifest_apply(host, pp) |
There was a problem hiding this comment.
Can you not use the Beaker built-in method "expect_failure" from Beaker-RSpec?
|
I don't see tests for '89123', '89124', '89125' or '89540'. |
| query = "USE #{db_name}; SELECT * FROM INFORMATION_SCHEMA.TABLES WHERE table_name = '#{table_name}';" | ||
| run_sql_query(host, run_sql_query_opts(@login_user, @login_passwd, query, 1)) | ||
|
|
||
| puts "Validate the login '#{@login_user}' is successfully created and has correct is_expiration_checked:" |
There was a problem hiding this comment.
Fixed in the next push
|
@cowofevil updated code passed local test. |
cowofevil
pushed a commit
that referenced
this pull request
Sep 15, 2015
…_sqlserver-login (MODULES-2497) SQLSERVER - Create Automated Tests for sqlserver::login
cowofevil
deleted the
MODULES-2497/automated_test_for_sqlserver-login
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.