(MODULES-2403) Improve error handling for sqlserver_tsql #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cyberious
commented
Aug 12, 2015
cyberious
commented
- Ensure we are capturing and throwing errors when we are unable to find dependencies
- Ensure we are capturing and throwing errors when we are unable to find dependencies
| @@ -19,7 +19,7 @@ def get_config | |||
| resc.original_parameters[:instance_name] =~ /#{instance}/i | |||
| } | |||
| if config_resc.nil? | |||
| fail("Sqlserver_tsql #{resource[:title]} was unable to retrieve the config for the instance #{resource[:instance]}") | |||
| fail("Sqlserver_tsql[#{resource.title}] was unable to retrieve the config, please ensure the catalog contains sqlserver::config{'#{resource[:instance]}':}") | |||
There was a problem hiding this comment.
catalog versus manifest? I typically prefer the word manifest, but I can see why catalog. Could be in another manifest.
ferventcoder
added a commit
that referenced
this pull request
Aug 14, 2015
(MODULES-2403) Improve error handling for sqlserver_tsql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.