(docs) Several docs updates #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cyberious
commented
Aug 12, 2015
cyberious
commented
- Updated docs for new scenarios and fix others
added 2 commits
August 12, 2015 14:26
- Add description about requirement of sqlserver:;config for sqlserver_tsql provider
- Add better description that the filename should be an absolute path
| @@ -28,6 +28,7 @@ def self.checks | |||
| end | |||
| end | |||
|
|
|||
| desc 'initial database to connect to during query execution' | |||
There was a problem hiding this comment.
Doesn't this need to go inside the newparam block?
There was a problem hiding this comment.
If so than we need to modify for all in this type as they are all outside the newparam block
There was a problem hiding this comment.
Yeah, sorry I didn't catch them before.
added 2 commits
August 13, 2015 09:44
- Add desc block to type - Add parameter to README
- desc blocks were being called outside the newparam block and need to move inside
ferventcoder
added a commit
that referenced
this pull request
Aug 13, 2015
(docs) Several docs updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.