(docs) MODULES-2325 update readme to reflect permissions #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Define types ::login::permissions and :;role::permissions as well as ::user:;permissions were in the singular form in the README and needed to be updated to reflect correct name
Contributor
|
I'm good with this. Would need a cursory review from someone on the docs team though. I'm not sure who that is, so cc @jbondpdx |
Contributor
|
Yep, it's me @ferventcoder . 👍 |
Contributor
|
@jbondpdx I assume the thumbs up means good to merge? :) |
Contributor
|
It does! On Thu, Aug 6, 2015 at 12:29 PM Rob Reynolds [email protected]
PuppetConf 2015 is coming to Portland, Oregon! Join us October 5-9. |
ferventcoder
added a commit
that referenced
this pull request
Aug 6, 2015
(docs) MODULES-2325 update readme to reflect permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
::user:;permissions were in the singular form in the README and needed
to be updated to reflect correct name