Skip to content

fix rake #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2017
Merged

fix rake #88

merged 1 commit into from
May 16, 2017

Conversation

TheMeier
Copy link

avoid failure with

rake aborted!
NoMethodError: undefined method `last_comment' for #Rake::Application:0x00560bba531620

@TheMeier
Copy link
Author

TheMeier commented May 11, 2017 •
edited
Loading

a better alternative might be to remove the version pinning for rspec/rake gem

TheMeier@a15c021

@esalberg esalberg mentioned this pull request May 15, 2017
Closed
@eputnam
Copy link
Contributor

eputnam commented May 15, 2017

@TheMeier you had the right idea with 39198b7, we just need to unpin rspec. Could you resubmit that and I opened #89 to fix the excludeAndInclude business. With our powers combined...

@TheMeier TheMeier force-pushed the patch-1 branch 2 times, most recently from c5d3473 to 2b9e4c0 Compare May 16, 2017 09:12
@TheMeier
fix rake
978b361 
avoid failure with

rake aborted!
NoMethodError: undefined method `last_comment' for #<Rake::Application:0x00560bba531620>
@TheMeier
Copy link
Author

I rebased the branch. Should be ok now

@eputnam eputnam merged commit f1bdf56 into puppetlabs:master May 16, 2017
@TheMeier TheMeier deleted the patch-1 branch May 29, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheMeier @eputnam