[PA-5586]: Add debian-12-x86_64 to the puppet agent module task acceptance #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
approved these changes
Mar 4, 2024
Contributor
kenyon
left a comment
kenyon
left a comment
There was a problem hiding this comment.
Minor thing, since these are regexps, the dot can match any character, which shouldn't cause an unexpected match, but I always like to escape characters that should be literal instead of regexp metacharacters. You could also use Regexp.escape here instead.
span786
force-pushed
the
PA-5586-add-debian-12-x86-64-to-the-puppet-agent-module-task-acceptance
branch
from
1b3a1f5 to
84a53a9
Compare
skyamgarp
reviewed
Mar 5, 2024
kenyon
approved these changes
Mar 6, 2024
kenyon
approved these changes
Mar 6, 2024
Contributor
Author
|
@bastelfreak can you please review this PR ? |
bastelfreak
approved these changes
Mar 6, 2024
mhashizume
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added debian-12 to the puppet agent module task acceptance