Skip to content

[PE-37297]: Added support for amazon 2023 in redhat.pp manifest file #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2024
Merged

[PE-37297]: Added support for amazon 2023 in redhat.pp manifest file #692

merged 1 commit into from
Jan 9, 2024

Conversation

@span786
Copy link
Contributor

@span786 span786 commented Dec 19, 2023

No description provided.

@span786 span786 requested review from a team and bastelfreak as code owners December 19, 2023 12:16
@span786 span786 force-pushed the PE-37297-4-add-amazon-linux-2023-to-puppet-agent-module-puppet-acceptance branch 2 times, most recently from 8149e5e to 076abee Compare December 19, 2023 13:35
@span786 span786 marked this pull request as draft December 19, 2023 16:02
donoghuc
donoghuc previously requested changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests and linter are pointing out some legit issues here.

@span786 span786 force-pushed the PE-37297-4-add-amazon-linux-2023-to-puppet-agent-module-puppet-acceptance branch from 076abee to 83d9680 Compare December 19, 2023 18:34
@span786 span786 marked this pull request as ready for review December 20, 2023 06:23
@span786 span786 requested a review from donoghuc December 21, 2023 05:35
@mhashizume
Copy link
Contributor

mhashizume commented Dec 21, 2023

Could you add a commit to bump beaker-hostgenerator in acceptance/Gemfile to ~> 2? Thank you!

mhashizume
mhashizume requested changes Dec 21, 2023
View reviewed changes
@span786 span786 force-pushed the PE-37297-4-add-amazon-linux-2023-to-puppet-agent-module-puppet-acceptance branch 2 times, most recently from d7fd990 to f59acf3 Compare December 26, 2023 07:25
@span786 span786 requested a review from mhashizume December 26, 2023 15:04
@span786 span786 force-pushed the PE-37297-4-add-amazon-linux-2023-to-puppet-agent-module-puppet-acceptance branch from f59acf3 to ff5c8ae Compare December 29, 2023 14:45
joshcooper
joshcooper reviewed Jan 2, 2024
View reviewed changes
@joshcooper
Copy link
Contributor

joshcooper commented Jan 2, 2024

Let's wait to merge this until this issue is resolved and builds are passing CI again puppetlabs/facter#2661

joshcooper
joshcooper previously requested changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my comment about 2018 still needs to be resolved?

bastelfreak
bastelfreak reviewed Jan 5, 2024
View reviewed changes
@span786 span786 force-pushed the PE-37297-4-add-amazon-linux-2023-to-puppet-agent-module-puppet-acceptance branch from ff5c8ae to 7de615d Compare January 8, 2024 06:27
mhashizume
mhashizume previously requested changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@mhashizume mhashizume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran this through the experimental pipeline and it looks good! https://jenkins-platform.delivery.puppetlabs.net/view/__experimental%20automatic/job/experimental_auto_puppetlabs-puppet-agent-module_intn-sys_pa-acceptance_7-nightly_to_8-nightly-adhoc/1/

Would you be able to squash your two commits into one please?

@span786
[PE-37297]: Added support for amazon 2023 in redhat.pp manifest file
d5ad156 
Optimized Amazon linux 2023 support code & tests
@span786 span786 force-pushed the PE-37297-4-add-amazon-linux-2023-to-puppet-agent-module-puppet-acceptance branch from 7de615d to d5ad156 Compare January 9, 2024 05:09
@span786 span786 requested a review from mhashizume January 9, 2024 05:10
@span786
Copy link
Contributor Author

span786 commented Jan 9, 2024

Commits have been squashed into one

@span786 span786 dismissed stale reviews from donoghuc, joshcooper, and mhashizume January 9, 2024 05:13

Implemented the requested review

@joshcooper joshcooper merged commit f1853b4 into puppetlabs:main Jan 9, 2024
@mhashizume mhashizume added the enhancement New feature or request label Jan 10, 2024
@joshcooper joshcooper mentioned this pull request Jan 19, 2024
Merged
@joshcooper joshcooper mentioned this pull request May 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshcooper joshcooper joshcooper approved these changes

@donoghuc donoghuc Awaiting requested review from donoghuc

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

@mhashizume mhashizume Awaiting requested review from mhashizume

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@span786 @mhashizume @joshcooper @bastelfreak @donoghuc